Use FormattingHelper#format_money in entitled_to_sick_pay outcome in SSP #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
We're trying to standardize on using this method to format money objects. The effect of this is to leave off the decimal point and the pence when the value is a whole number of pounds. @lutgendorff confirmed that this was probably just an accidental difference and so I'm fixing it here. Note that many of the regression test artefacts need to be updated, but I plan to do that in a separate commit so it's easier to see what's going on.
These changes are all due to the use of `FormattingHelper#format_money` in the `entitled_to_sick_pay.govspeak.erb` outcome template for SSP.
floehopper
force-pushed
the
use-format-money-in-entitled-to-sick-pay-outcome
branch
from
a1a2ab0 to
deb620a
Compare
floehopper
added a commit
that referenced
this pull request
Nov 18, 2015
…o-sick-pay-outcome Use FormattingHelper#format_money in entitled_to_sick_pay outcome in SSP
floehopper
deleted the
use-format-money-in-entitled-to-sick-pay-outcome
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to standardize on using this method to format money objects.
The effect of this is to leave off the decimal point and the pence when the
value is a whole number of pounds.
@lutgendorff confirmed that this was probably just an accidental difference and
so I'm fixing it here.
Expected changes
Before
After