Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update student allowance outcome #2218

Merged
merged 3 commits into from
Dec 22, 2015
Merged

Update student allowance outcome #2218

merged 3 commits into from
Dec 22, 2015

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Dec 22, 2015

This PR supersedes #2190

Change 'two' to '2', and change case of 'year' in 'academic year' because style.

Expected changes

  • URL on gov.uk
    • The first sentance should replace the word two with the number 2
    • Both instances of table header Academic Year should appear as Academic year

Before

screen shot 2015-12-15 at 07 07 33

After

screen shot 2015-12-15 at 07 07 38

Note: this PR supersedes #2191 which was merged to the master branch, but reverted after the merge to the release branch by Jenkins failed.

keithiopia and others added 3 commits December 22, 2015 22:52
Execute:

 rails r script/generate-checksums-for-smart-answer.rb student-finance-forms
Execute:
 
 RUN_REGRESSION_TESTS=student-finance-forms ruby test/regression/smart_answers_regression_test.rb
erkde pushed a commit that referenced this pull request Dec 22, 2015
Update student allowance outcome
@erkde erkde merged commit f32782a into master Dec 22, 2015
@erkde erkde deleted the patch-21 branch December 22, 2015 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants