Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update student finance style #2219

Merged
merged 3 commits into from
Dec 22, 2015
Merged

Update student finance style #2219

merged 3 commits into from
Dec 22, 2015

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Dec 22, 2015

This PR supersedes #2195

Change case of 'year' in 'academic year' because style.

Expected changes

  • URL on gov.uk
    • Change table header from 'Academic Year' to 'Academic year'

Before

screen shot 2015-12-16 at 8 41 29 am

After

screen shot 2015-12-16 at 8 41 33 am

Note: this branch was previously merged in PR #2196 but was later removed, after Jenkins failed to merge it to the release branch during the build.

John Ploughman and others added 3 commits December 22, 2015 22:58
Corrected 'Academic Year' to 'Academic year' in the table header.
Execute:

 rails r script/generate-checksums-for-smart-answer.rb student-finance-forms
Execute:

 RUN_REGRESSION_TESTS=student-finance-forms ruby test/regression/smart_answers_regression_test.rb
erkde pushed a commit that referenced this pull request Dec 22, 2015
@erkde erkde merged commit 665ce54 into master Dec 22, 2015
@erkde erkde deleted the update_student_finance_style branch December 22, 2015 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant