Update header alignment to match layout #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly related: alphagov/govuk-frontend#1502 |
alex-ju
approved these changes
Nov 19, 2019
NickColley
force-pushed
the
update-alignment
branch
from
4d00d49 to
8f52dba
Compare
|
I've made a small tweak to align this a bit more:
|
|
@alex-ju if you could help us document where you've done similar things by commenting upstream here: alphagov/govuk-frontend#1502 that'd be really helpful. |
|
I've asked the graphic designers if I could get an extra pair of eyes on this so will see what they think. Latest:
|
NickColley
force-pushed
the
update-alignment
branch
from
8f52dba to
e0eea92
Compare
|
Laurence B and Charlotte D from the GDS graphic designer community have said they approve of this change so I'm going to get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to address some spacing issues introduced when this format was updated to use the GOV.UK Design System by aligning the header and layout elements on the page.
It also expands the width of the area for the product name which stops it wrapping early, this is something we might want to consider pushing upstream to GOV.UK Frontend in the future.
Fixes #164