Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redcarpet to 3.5.1 to fix CVE-2020-26298 #226

Merged
merged 4 commits into from
May 25, 2021

Conversation

pritchyspritch
Copy link
Contributor

@pritchyspritch pritchyspritch commented Apr 30, 2021

I noticed this outdated dependency on the cyber tech docs and saw that it was a sub-dependency of this gem. For some reason I don't have write access so I couldn't do a direct PR (I am a member Alphagov though).

  • Update redcarpet to 3.5.1 to fix CVE-2020-26298
  • I've added a comment to the CHANGELOG, title set to unreleased
  • Haven't bumped the version yet, in case you need other fixes first

Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the PR!

@pritchyspritch
Copy link
Contributor Author

This looks good to me. Thanks for the PR!

No worries! I haven't changed the release yet and don't have write access so am unable to merge it myself.

@lfdebrux lfdebrux merged commit 4f14a5f into alphagov:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants