Fix focus state for links containing inline code #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
approved these changes
Jul 15, 2021
Inheriting the background from the link means that the code block ends up with its own yellow background, which then clips the box-shadow used to give the focused link a black underline. Rather than inherit the yellow background, set the background to transparent. The focused link still has its own yellow background which can be seen ‘through’ the transparent code element.
36degrees
force-pushed
the
code-in-links-focus-style
branch
from
bffd69d to
220444e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheriting the background from the link means that the code block ends up with its own yellow background, which then clips the box-shadow used to give the focused link a black underline.
Rather than inherit the yellow background, set the background to transparent. The focused link still has its own yellow background which can be seen ‘through’ the transparent code element.
Before
After