Update Rack to 1.6.1 #2175
Merged
Update Rack to 1.6.1 #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I think we should specify that we want 1.6.1 or higher in the Gemfile. It's far easier to track through git logs that way. |
|
Ooh, I haven't had this debate here yet! Personally, I disagree. I think that's what the lockfile is for. But I see the other side of the argument too. Is there a consensus here on this? |
This fixes a bug where all form fields in a request are counted against the multipart file limit: rack/rack#814 This is an issue in production - some publications and organisations have a large number of dynamically added nested forms. When the form is submitted, a 500 is returned because the number of fields exceeds the limit. It only affects forms posted with multipart, e.g. ones that contain file fields. Zendesk: https://govuk.zendesk.com/agent/tickets/1037587 Story: https://www.pivotaltracker.com/story/show/94668330
|
After more thought - you're right. Added, plus comment. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where all form fields in a request are counted against the multipart file limit:
rack/rack#814
This is an issue in production - some publications and organisations have a large number of dynamically added nested forms. When the form is submitted, a 500 is returned because the number of fields exceeds the limit. It only affects forms posted with multipart, e.g. ones that contain file fields.
Zendesk: https://govuk.zendesk.com/agent/tickets/1037587
Story: https://www.pivotaltracker.com/story/show/94668330