Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set the reference commit for the branch list #82

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Allow to set the reference commit for the branch list #82

merged 4 commits into from
Jul 9, 2019

Conversation

smaret
Copy link
Contributor

@smaret smaret commented Jun 26, 2019

Closes #80.

@smaret smaret changed the title Add: Allow to set the reference commit for the branch list Allow to set the reference commit for the branch list Jun 26, 2019
alphapapa
alphapapa requested changes Jun 26, 2019
View reviewed changes
Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. If you wouldn't mind making these changes, I'll then add documentation to the readme and merge it.

magit-todos.el Outdated Show resolved Hide resolved
magit-todos.el Outdated Show resolved Hide resolved
@smaret
Copy link
Contributor Author

smaret commented Jun 26, 2019

Thanks for the review. I've made the changes you suggested.

alphapapa and others added 4 commits July 9, 2019 00:18
@alphapapa
Fix: (--delete-section) Don't delete past end of buffer
038f3ef 
This can happen if e.g. updating is disabled and no items have been
inserted yet.  Possibly introduced in 2d48f84.
@alphapapa
Fix: (--scan-with-rg) Use --line-number option to rg
02bf59e 
Not necessary now, but without this option, rg doesn't output line
numbers when called by Emacs with call-process, which will be used for
synchronous scans.
@alphapapa
Fix: (--scan-with-git-diff) Silence unused var warnings
efdaaf4
@smaret @alphapapa
Add: Allow to set the commit ref for the branch diff list
d58c866 
Closes #80.
@alphapapa alphapapa merged commit d58c866 into alphapapa:master Jul 9, 2019
@alphapapa
Copy link
Owner

Thanks!

@alphapapa
Copy link
Owner

BTW, I made a small mistake when rebasing, but I've fixed it on master now.

@smaret smaret deleted the set-ref-commit-todo-in-branch branch July 9, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphapapa alphapapa alphapapa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to highlight todos in current branch vs. master?
2 participants
@smaret @alphapapa