Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views not saved persistently #378

Closed
Pentaquark1 opened this issue Oct 12, 2023 · 5 comments
Closed

Views not saved persistently #378

Pentaquark1 opened this issue Oct 12, 2023 · 5 comments
Assignees
Milestone

Comments

@Pentaquark1
Copy link

Hi,

when I save an org-ql-search, it will show up in helm-org-ql-views and all the other related functions that show saved views.
However after restarting emacs, only the default views show up.

Using latest doom emacs, org-mode 9.7, Gnu Emacs 29.1

BR

@alphapapa
Copy link
Owner

alphapapa commented Oct 12, 2023

Hello,

Please try to reproduce the problem in a clean Emacs configuration, e.g. using https://github.com/alphapapa/with-emacs.sh

Also, FYI, you can save the views as Emacs bookmarks instead, e.g. with C-x r m.

@Pentaquark1
Copy link
Author

Pentaquark1 commented Oct 13, 2023

Hi,
let me know if I did this right:

  • cloned that repo, then ran it with ./with-emacs.sh -i org-ql --dir ~/new-emacs.d
  • then created some random view, saved the view. checked with org-ql-view that it shows up, it does
  • closed emacs, then ran it with the exact same cmd as above again, checked org-ql-view, my random view is not there anymore

That tip with Emacs bookmarks is nice. I checked my bookmarks and there was a burly bookmark of a view that I apparently made while tinkering and forgot about. That method might serve just fine as well.

@alphapapa
Copy link
Owner

Thanks. I can confirm the bug now. Something must have changed in recent Emacs versions. Should be a simple fix.

@alphapapa alphapapa self-assigned this Oct 13, 2023
@alphapapa alphapapa added this to the 0.7.3 milestone Oct 13, 2023
alphapapa added a commit that referenced this issue Oct 20, 2023
It didn't seem that calling custom-save-all was necessary in the past,
but it appears that it is now.

Closes #378.

Reported-by: Pentaquark1 <https://github.com/Pentaquark1>
@alphapapa
Copy link
Owner

@Pentaquark1 I think that will fix it. Would you please install from this branch and let me know if it works for you? https://github.com/alphapapa/org-ql/tree/stable/0.7

@alphapapa
Copy link
Owner

Seems to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants