Revert "Proof of concept of SVG icons next to external header links (s…

…cientific-python#163)" This reverts commit b147a37. See discussion starting at <scientific-python#233 (comment)>. This feature may be reintroduced and documented later.
alphapapa · Sep 27, 2023 · 1376b95 · 1376b95
1 parent 1de1a03
commit 1376b95
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 14 deletions.
diff --git a/assets/theme-css/styles.css b/assets/theme-css/styles.css
@@ -308,10 +308,6 @@ svg.icon {
   vertical-align: middle;
 }
 
-.navbar svg.icon {
-  width: 1.5rem;
-}
-
 #footer .community-icons {
   /* Icon size slightly enlargened for footer */
   font-size: 2.3em;

diff --git a/doc/config.yaml b/doc/config.yaml
@@ -25,7 +25,6 @@ params:
       url: /getstarted/
     - title: Features
       url: /features/
-      is_external: true
     - title: Shortcodes
       url: /shortcodes/
   keyfeatures:

diff --git a/layouts/partials/navbar-clone.html b/layouts/partials/navbar-clone.html
@@ -12,7 +12,6 @@
       </a>
       {{- end}}
 
-
       <a role="button" class="navbar-burger" aria-label="menu" aria-expanded="false" data-target="cloned-navbar-menu">
         <span aria-hidden="true"></span>
         <span aria-hidden="true"></span>
@@ -28,14 +27,12 @@
         <div class="navbar-item has-dropdown is-hoverable">
           <a class="navbar-link">
             {{ .title }}
-            {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
           </a>
 
           <div class="navbar-dropdown">
             {{- range .sublinks }}
             <a href="{{ .url }}" class="navbar-item">
               {{ .title }}
-              {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
             </a>
             {{- end }}
           </div>
@@ -44,13 +41,11 @@
         <a href="{{ .url }}" class="navbar-item">
           <span class="button signup-button rounded secondary-btn raised">
             {{ .title }}
-            {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
           </span>
         </a>
         {{- else }}
         <a href="{{ .url }}" class="navbar-item is-secondary">
           {{ .title }}
-          {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
         </a>
         {{- end }}
         {{- end }}

diff --git a/layouts/partials/navbar.html b/layouts/partials/navbar.html
@@ -29,14 +29,12 @@
         <div class="navbar-item has-dropdown is-hoverable">
           <a class="navbar-link">
             {{ .title }}
-            {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
           </a>
 
           <div class="navbar-dropdown">
             {{- range .sublinks }}
             <a href="{{ .url }}" class="navbar-item">
               {{ .title }}
-              {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
             </a>
             {{- end }}
           </div>
@@ -45,13 +43,11 @@
         <a href="{{ .url }}" class="navbar-item">
           <span class="button signup-button rounded secondary-btn raised">
             {{ .title }}
-            {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
           </span>
         </a>
         {{- else }}
         <a href="{{ .url }}" class="navbar-item is-secondary">
           {{ .title }}
-          {{ if .is_external }}{{ partial "svg-icon" "launch" }}{{ end }}
         </a>
         {{- end }}
         {{- end }}

diff --git a/assets/icons/launch.svg → static/images/icons/launch.svg b/assets/icons/launch.svg → static/images/icons/launch.svg