Relax pixel width and height check to determine the ratio #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Aseprite File Format Specification says the following about the pixel
width and pixel height fields:
BYTE Pixel width (pixel ratio is "pixel width/pixel height").
If this or pixel height field is zero, pixel ratio is 1:1
BYTE Pixel height
But the read_aseprite() function only considers a 1:1 pixel ratio if both
width and height values are 1, and not when one of these has zero value.
There are some Aseprite editors (such as LibreSprite) that don't set these
fields, even when only supports a 1:1 pixel ratio. But due read_aseprite()
being that strict in checking the width and height, these Aseprite files
can't be read and attempting to do so will fail with the following error:
UnsupportedFeature("Only pixel width:height ratio of 1:1 supported")
martinezjavier
force-pushed
the
relax-pixel-ratio-check
branch
from
03bf8ef
to
b9f745b
Compare
martinezjavier
changed the title
|
@alpine-alpaca @B-Reif any comments on this ? |
|
I’m not a maintainer of this repo, but if this is spec compliant then LGTM |
Thanks! It seems this repo is abandoned... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Aseprite File Format Specification says the following about the pixel width and pixel height fields:
BYTE Pixel width (pixel ratio is "pixel width/pixel height").
If this or pixel height field is zero, pixel ratio is 1:1
BYTE Pixel height
But the read_aseprite() function only considers a 1:1 pixel ratio if both width and height values are 1, and not when one of these has zero value.
There are some Aseprite editors (such as LibreSprite) that don't set these fields, even when only supports a 1:1 pixel ratio. But due read_aseprite() being that strict in checking the width and height, these Aseprite files can't be read and attempting to do so will fail with the following error:
UnsupportedFeature("Only pixel width:height ratio of 1:1 supported")