Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PythonCoderAS
Copy link

No description provided.

@ozbillwang
Copy link
Contributor

ozbillwang commented Jan 13, 2024

Thank you for submitting the PRs (#2 and #3). I've reviewed both of them, and it appears they mainly address formatting and linting features, similar to the existing one, alpine/flake8.

Maintaining two additional docker images does require additional time. Could we consider merging them into the existing one, alpine/flake8? I understand that the name might be a bit confusing and unclear, but consolidating them would streamline future maintenance, saving us valuable time in the long run.

@ozbillwang
Copy link
Contributor

or we stop updating alpine/flake8 any more, migrate it to new image, such as alpine/py-lint? or other name you can recommend.

in this new image, we can put all formatter and lint packages in it, such as flake8, yapf, black, ruff, etc?

@PythonCoderAS
Copy link
Author

or we stop updating alpine/flake8 any more, migrate it to new image, such as alpine/py-lint? or other name you can recommend.

in this new image, we can put all formatter and lint packages in it, such as flake8, yapf, black, ruff, etc?

The entire point of basing these off of an alpine base image was to get the smallest image size possible though, otherwise someone would just use the Python base image and just pip install them. It might be possible to configure automatic updating somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants