-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$focus: Add 'onlyTabbables' modifier #3615
Conversation
Failing tests are outside the scope of this PR. |
What's the difference between a tabbable and a focusable? |
More info in their readme: https://github.com/focus-trap/tabbable |
an input with tabindex = -1 is focusable but not tabbable @valincius isn't the syntax a bit inconsistent? |
@SimoTod I went with this syntax to allow for reusing all of the other methods that build off of I will draft up something else. Feel free to provide any suggestions. What if I were to get rid of the
|
I've updated this to better fit the current api, could I get a review? |
Thanks for contributing! In order to keep Alpine as focused and maintainable as possible, I'm going to close this pull request. This isn't "no", it's just "no for now". If you disagree, or there's further demand from the community, please re-open this PR and we'll reconsider! |
This PR adds
tabbables
modifier to$focus
plugin to allow traversing ONLY the tabbable elements.