馃悰 Fixes issue with setters accessing deeply nested data #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooof, this is great stuff, thank you @ekwoka |
This was referenced Jul 10, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue presented in Discord
Apparently there is an upstream bug in @vue/reactivity that, when using a setter to access deeply nested data on a part of
thisthat was not in the same object, would error out. As vue was not respecting thethiscontext when using reflection.I intend to make a PR there to address this as well, but Alpine is broken by even updating one minor version, so this still needs to be addressed here.
The issue can be demonstrated here:
3.13.0
3.13.1
馃槥