Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for template tag when there are sibling x-for #851

Merged
merged 7 commits into from
Nov 2, 2020
Merged

Add check for template tag when there are sibling x-for #851

merged 7 commits into from
Nov 2, 2020

Conversation

KevinBatdorf
Copy link
Contributor

Likely fixes #834

I'm not totally familiar with this part of the code to be fair, but all the tests are passing, and the test I added fails otherwise.

@KevinBatdorf
Copy link
Contributor Author

The title isn't totally accurate. It will now just ignore anything that isn't keyed, not just template tags

@calebporzio
Copy link
Collaborator

Yep, this makes good sense. Thanks so much for pitching in on this @KevinBatdorf!

@calebporzio calebporzio merged commit e501ed2 into alpinejs:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-for adjacent to another x-for throws not defined error
2 participants