Merge pull request #143 from alps-asd/exception-name

Change exception name
alps-asd · Dec 18, 2021 · 537afb0 · 537afb0
2 parents 175c97a + d3d589e
commit 537afb0
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 66 deletions.
diff --git a/src/DrawDiagram.php b/src/DrawDiagram.php
@@ -6,7 +6,7 @@
 
 use JetBrains\PhpStorm\Immutable;
 use Koriym\AppStateDiagram\Exception\InvalidHrefException;
-use Koriym\AppStateDiagram\Exception\SharpMissingInHrefException;
+use Koriym\AppStateDiagram\Exception\MissingHashSignInHrefException;
 use stdClass;
 
 use function assert;
@@ -174,7 +174,7 @@ private function isSemanticHref(stdClass $item, array $descriptors): bool
 
         $pos = strpos($item->href, '#');
         if ($pos === false) {
-            throw new SharpMissingInHrefException($item->href); // @codeCoverageIgnore
+            throw new MissingHashSignInHrefException($item->href); // @codeCoverageIgnore
         }
 
         $id = substr($item->href, $pos + 1);

diff --git a/src/Exception/InvalidDirPathException.php b/src/Exception/InvalidDirPathException.php
diff --git a/src/Exception/InvalidJsonException.php → ...eption/MissingHashSignInHrefException.php b/src/Exception/InvalidJsonException.php → ...eption/MissingHashSignInHrefException.php
@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class InvalidJsonException extends RuntimeException
+class MissingHashSignInHrefException extends RuntimeException
 {
 }
diff --git a/src/Exception/RtMissingException.php → src/Exception/MissingRtException.php b/src/Exception/RtMissingException.php → src/Exception/MissingRtException.php
@@ -6,6 +6,6 @@
 
 use RuntimeException;
 
-class RtMissingException extends RuntimeException
+class MissingRtException extends RuntimeException
 {
 }
diff --git a/src/Exception/NonSemanticLinkException.php b/src/Exception/NonSemanticLinkException.php
diff --git a/src/Exception/RtDescriptorMissingException.php b/src/Exception/RtDescriptorMissingException.php
diff --git a/src/Exception/RtNotRefException.php b/src/Exception/RtNotRefException.php
diff --git a/src/Exception/SharpMissingInHrefException.php b/src/Exception/SharpMissingInHrefException.php
diff --git a/src/Exception/TypeSemanticException.php b/src/Exception/TypeSemanticException.php
diff --git a/src/HyperReference.php b/src/HyperReference.php
@@ -5,7 +5,7 @@
 namespace Koriym\AppStateDiagram;
 
 use Generator;
-use Koriym\AppStateDiagram\Exception\SharpMissingInHrefException;
+use Koriym\AppStateDiagram\Exception\MissingHashSignInHrefException;
 use stdClass;
 
 use function array_shift;
@@ -38,7 +38,7 @@ public function add(string $alpsFile, string $href): void
     {
         $fullPath = ($this->fullPath)($alpsFile, $href);
         if (! is_int(strpos($fullPath, '#'))) {
-            throw new SharpMissingInHrefException($href);
+            throw new MissingHashSignInHrefException($href);
         }
 
         [, $id] = explode('#', $fullPath);

diff --git a/src/TransDescriptor.php b/src/TransDescriptor.php
@@ -4,7 +4,7 @@
 
 namespace Koriym\AppStateDiagram;
 
-use Koriym\AppStateDiagram\Exception\RtMissingException;
+use Koriym\AppStateDiagram\Exception\MissingRtException;
 use stdClass;
 
 use function assert;
@@ -31,14 +31,14 @@ public function __construct(stdClass $descriptor, SemanticDescriptor $parent)
         if (! isset($descriptor->rt) || ! is_string($descriptor->rt)) {
             assert(is_string($descriptor->id));
 
-            throw new RtMissingException($descriptor->id);
+            throw new MissingRtException($descriptor->id);
         }
 
         assert(is_string($descriptor->id));
 
         $pos = strpos($descriptor->rt, '#');
         if ($pos === false) {
-            throw new RtMissingException($descriptor->id);
+            throw new MissingRtException($descriptor->id);
         }
 
         $this->rt = substr($descriptor->rt, $pos + 1);

diff --git a/tests/AlpsProfileTest.php b/tests/AlpsProfileTest.php
@@ -7,7 +7,7 @@
 use Koriym\AppStateDiagram\Exception\AlpsFileNotReadableException;
 use Koriym\AppStateDiagram\Exception\DescriptorNotFoundException;
 use Koriym\AppStateDiagram\Exception\InvalidLinkRelationException;
-use Koriym\AppStateDiagram\Exception\SharpMissingInHrefException;
+use Koriym\AppStateDiagram\Exception\MissingHashSignInHrefException;
 use PHPUnit\Framework\TestCase;
 
 use function stream_wrapper_register;
@@ -99,7 +99,7 @@ public function testNoRelLink(): void
 
     public function testNoRtTransDescriptor(): void
     {
-        $this->expectException(SharpMissingInHrefException::class);
+        $this->expectException(MissingHashSignInHrefException::class);
         new Profile(__DIR__ . '/Fake/invalid_rt_descriptor.json', new LabelName());
     }
 }
diff --git a/tests/ErrorTest.php b/tests/ErrorTest.php
@@ -9,7 +9,7 @@
 use Koriym\AppStateDiagram\Exception\InvalidDescriptorException;
 use Koriym\AppStateDiagram\Exception\InvalidLabelOptionException;
 use Koriym\AppStateDiagram\Exception\InvalidSemanticsException;
-use Koriym\AppStateDiagram\Exception\RtMissingException;
+use Koriym\AppStateDiagram\Exception\MissingRtException;
 use PHPUnit\Framework\TestCase;
 use Seld\JsonLint\ParsingException;
 
@@ -36,7 +36,7 @@ public function testInvalidDescriptorInDescriptor(): void
 
     public function testMissingRt(): void
     {
-        $this->expectException(RtMissingException::class);
+        $this->expectException(MissingRtException::class);
         (new DrawDiagram())(new Profile(__DIR__ . '/Fake/invalid_missing_rt.json', new LabelName()), new LabelName());
     }
 
@@ -67,7 +67,7 @@ public function testInvalidDescriptor(): void
 
     public function testRtMissing(): void
     {
-        $this->expectException(RtMissingException::class);
+        $this->expectException(MissingRtException::class);
         $invalidTrans = (object) ['id' => 'id', 'type' => 'safe', 'rt' => ''];
         $semantic = new SemanticDescriptor(new class {
             /** @var string */