Skip to content

Commit

Permalink
Remove needless manual default impl of ButtonBundle (bevyengine#6970)
Browse files Browse the repository at this point in the history
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
  • Loading branch information
nicopap authored and alradish committed Jan 22, 2023
1 parent dc0f589 commit 3be8473
Showing 1 changed file with 2 additions and 21 deletions.
23 changes: 2 additions & 21 deletions crates/bevy_ui/src/node_bundles.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ pub struct ImageBundle {
pub calculated_size: CalculatedSize,
/// The background color, which serves as a "fill" for this node
///
/// When combined with `UiImage`, tints the provided image.
/// Combines with `UiImage` to tint the provided image.
pub background_color: BackgroundColor,
/// The image of the node
pub image: UiImage,
Expand Down Expand Up @@ -178,7 +178,7 @@ impl Default for TextBundle {
}

/// A UI node that is a button
#[derive(Bundle, Clone, Debug)]
#[derive(Bundle, Clone, Debug, Default)]
pub struct ButtonBundle {
/// Describes the size of the node
pub node: Node,
Expand Down Expand Up @@ -213,22 +213,3 @@ pub struct ButtonBundle {
/// Indicates the depth at which the node should appear in the UI
pub z_index: ZIndex,
}

impl Default for ButtonBundle {
fn default() -> Self {
ButtonBundle {
button: Button,
interaction: Default::default(),
focus_policy: Default::default(),
node: Default::default(),
style: Default::default(),
background_color: Default::default(),
image: Default::default(),
transform: Default::default(),
global_transform: Default::default(),
visibility: Default::default(),
computed_visibility: Default::default(),
z_index: Default::default(),
}
}
}

0 comments on commit 3be8473

Please sign in to comment.