♻️ Make minor improvements

alrra · Oct 11, 2020 · 5ffbcb3 · 5ffbcb3
1 parent 509ee4d
commit 5ffbcb3
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 22 deletions.
diff --git a/bin/clean-whiteboard-photos b/bin/clean-whiteboard-photos
@@ -33,17 +33,16 @@ clean_whiteboard_photos() {
 main() {
 
     # Check if ImageMagick's convert command-line tool is installed
-    if [ -x "$(command -v "convert")" ]; then
-
-        while [ $# -ne 0 ]; do
-            clean_whiteboard_photos "$1"
-            shift
-        done
-
-    else
+    if [ ! -x "$(command -v "convert")" ]; then
         printf "Please install ImageMagick's 'convert' command-line tool!"
+        exit;
     fi
 
+    while [ $# -ne 0 ]; do
+        clean_whiteboard_photos "$1"
+        shift
+    done
+
 }
 
-main $@
+main "$@"
diff --git a/bin/get-compression-heatmap b/bin/get-compression-heatmap
@@ -49,15 +49,15 @@ main() {
 
     # Check if `cURL` is installed
     if [ ! -x "$(command -v "curl")" ]; then
-        printf "Please install cURL!\n"
+        printf "cURL is required, please install it!\n"
         exit;
     fi
 
     while [ $# -ne 0 ]; do
 
         tmpFile="/tmp/$(mktemp -u XXXXX).gz"
 
-        # Check if the current command line arguments is a local file
+        # Check if the current command line argument is a local file
         if [ -f "$1" ]; then
             cmd="cat"
 

diff --git a/bin/get-content-encoding b/bin/get-content-encoding
@@ -2,8 +2,8 @@
 
 # DESCRIPTION:
 #
-#   Provides the content encoding the specified
-#   resources are served with.
+#   Provides the content encoding the
+#   specified resources are served with.
 #
 # USAGE:
 #
@@ -167,17 +167,19 @@ get_content_encoding() {
 
 main() {
 
-    # Check if cURL is installed
-    if [ -x "$(command -v "curl")" ]; then
-        while [ $# -ne 0 ]; do
-            get_content_encoding "$1"
-            shift
-        done
-        printf "\n"
-    else
+    # Check if `cURL` is installed
+    if [ ! -x "$(command -v "curl")" ]; then
         printf "cURL is required, please install it!\n"
+        exit;
     fi
 
+    while [ $# -ne 0 ]; do
+        get_content_encoding "$1"
+        shift
+    done
+
+    printf "\n"
+
 }
 
-main $@
+main "$@"