Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(tests): Add a test to validate
scripts/migration/renamings.js
(g…
…oogle#5980) * feat(tests): Add a test script for the renamings file * Make scripts/migration/renamings.js a valid JSON5 file. * Add a schema for it in tests/migration/renamings-schema.json. * Add a script to test one against the other, as tests/migration/validate-renamings. It is a node.js script that will exit 0 if the renamings file is valid, or 1 if it is not (and print a not-very-helpful error message from which is possible, with some effort, to deduce what the error is.) * fix: convert to JSON5 and refactor example * fix: convert keys to new key names * fix: change versions to arrays instead of objects * fix: fix version numbers * fix: associate renames with the version where they were added * fix: fixup example * fix: put older renames at the bottom, and newer renames at the top * fix: enable renamings test in run_all_tests * fix: put newer renames back at the bottom This reverts commit efe070e. * fix(tests): add missing additionalProperties: false to schema And fix the resulting validation error in the example entry. * chore(tests): Improve wording of example entry; add extra examples Tweaked line wrapping of some existing entries (example and acutal) that were otherwise untouched. * feat: add dropDownDiv renaming to new database * feat(tests): Check for duplicate entries for the same module Also fixed extraneous whitespace in run_all_tests.sh * fix(tests): Make validate-renamings.js compatible with node.js v12 Also remove success message, to adhere to usual unix convention (silence implies success) as eslint does, and reduce unecessary npm test output clutter. * fix(tests): Fixes for PR google#5980 * Fix typos. * Remove redundant check. Co-authored-by: Beka Westberg <bwestberg@google.com>
- Loading branch information