Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update academicons to 1.9.4 #1731

Closed
wants to merge 28 commits into from
Closed

update academicons to 1.9.4 #1731

wants to merge 28 commits into from

Conversation

global-anomaly
Copy link
Contributor

This addresses the #1704 issue.

I have changed the following,

  • changed academmhcons from cdn to local installation (v1.9.4)
  • added the arXiv social which uses the new icon as required in New arXiv favicon #1704

george-gca and others added 11 commits July 14, 2023 14:57
@george-gca
Added sass compression, updated bootstrap table version
24734e6 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Fixed some spacing
8663e48 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Changed some cdn libraries for local libraries
39f73e0 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added purgecss commands to deploy
5e4895f 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added purgecss command to README
e1a368b 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added missing js map files
fed0491 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added missing css map files
c34c738 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Merge branch 'master' into purgecss
3d35a41
@george-gca
Added missing bust file cache to syntax highlight css
cb2d7b6 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added missing academicons fonts
dd36c8a 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@george-gca
Added bust file cache for more assets
f867e4a 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@alshedivat
Copy link
Owner

I suggest rebasing this on top of #1562, testing, and merging it after #1562 lands.

@alshedivat alshedivat linked an issue Sep 17, 2023 that may be closed by this pull request
New arXiv favicon #1704
Closed
george-gca and others added 16 commits September 20, 2023 06:05
@george-gca @global-anomaly
Added jupyter to README (#1637)
f47a4ff 
Signed-off-by: George Araujo <george.gcac@gmail.com>
@danberlyne @global-anomaly
add star to academic examples (#1647)
7bfba78 
Dear `al-folio` maintainers,

I would greatly appreciate it if you could add my homepage as a star in
the academic examples.

Thank you for your wonderful work on this.
@pourmand1376 @global-anomaly
Update README to make Docker Recommended way (#1523)
1e3969b 
Docker is well-tested for a long time. I think it is better to make it
the recommended method for all OS types.

This way, it is a lot easier to install docker (than to install jekyll
and ruby and what not) and also we wouldn't have to deal with issues
like these:
- #1520
- #1491
@filippomazzoli @global-anomaly
Update README.md (#1657)
2c207d8
@Alescontrela @global-anomaly
Update README.md (#1661)
1b2d315 
add star to academic example
@alshedivat @global-anomaly
Add all contributors section to README.md
6550017
@raffaem @global-anomaly
Fix _variables.scss filename in README (#1683)
72bd7c4
@raffaem @global-anomaly
Add website (#1674)
a4ceeb1
@raffaem @global-anomaly
Don't display badge if startDate is empty (#1682)
e9d3405
@kyleaoman @global-anomaly
Add a star. (#1695)
2c1d5f6
@cbueth @george-gca @global-anomaly
Add star to README.md (#1684)
591bccb 
Added academic website to README.md.
Also added `_blank` target to earlier ones.

Co-authored-by: George <31376482+george-gca@users.noreply.github.com>
@Decwest @global-anomaly
Add a star (#1705)
7f8e5e1 
Added academic website to README.md.
@jedbur @global-anomaly
Add a star (#1723)
955e6ed
@global-anomaly
Update: academicons 1.9.1 --> 1.9.4
6d63b65 
- changed from cdn to local installation.
- no use for the academicons key in _config.yml (but kept it there for future use)
@global-anomaly
Add: arXiv in social.html
cf44ff1
@global-anomaly
update fonts folder structure
24925a0
@global-anomaly
Copy link
Contributor Author

global-anomaly commented Sep 20, 2023 •
edited
Loading

I suggest rebasing this on top of #1562, testing, and merging it after #1562 lands.

Okay, I did something. No idea if I did it correctly. But something is done. Please let me know if I messed up. Thank you

PS. Tested locally and it is compiling properly.

@global-anomaly
Copy link
Contributor Author

global-anomaly commented Sep 22, 2023 •
edited
Loading

Wow, this actually improved my website's pagespeed score. You can check the score here.

Mobile
image
Desktop
image

Edit 1: I have updated the bootstrap and mdb and fixed most of the changes in my version of the website which can be found in this commit. If you want I can add them slowly to this pull request as well.

Edit 2: I need some help with caching the static assets. Please do comment on that. Thanks

@george-gca
Copy link
Collaborator

Sorry, I am quite in a busy couple of weeks. I can take a look at it, but not until weekend of next week

@george-gca
Copy link
Collaborator

I believe this is now fixed since academicons 1.9.4 was already added in #1562. @TheFermi0n can you check if this is still needed?

@global-anomaly
Copy link
Contributor Author

if this is still needed?

Sorry for the late response. No, I don't think this is still needed. I am closing this pull request. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-gca george-gca Awaiting requested review from george-gca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New arXiv favicon