Bugfix: Updates ninja keys text input color so it is always visible #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-gca
approved these changes
May 31, 2024
|
Thanks for noticing this. |
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this pull request
Dec 29, 2024
…lshedivat#2463) This PR fixes an issue where the search input is not visible in the light theme. This is because `ninja-header-min.js` defaults the text color to white. This style change will ensure that the text is always visible regardless of theme selection ## Before Style Change <img width="1435" alt="SCR-20240530-cnxd" src="https://github.com/alshedivat/al-folio/assets/16251412/dbbc04c6-6e23-4bb5-8278-218d4e0e1329"> ## After Style Change <img width="1434" alt="SCR-20240530-coqb" src="https://github.com/alshedivat/al-folio/assets/16251412/182df8e5-8f54-4eca-a255-b8efbf52db9d">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the search input is not visible in the light theme. This is because
ninja-header-min.jsdefaults the text color to white.This style change will ensure that the text is always visible regardless of theme selection
Before Style Change
After Style Change