Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QCheckbox): add labelSize props and redesign #306

Merged
merged 22 commits into from
Jul 12, 2022
Merged

Conversation

VasiliyRusin
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for qui-docs ready!

Name Link
🔨 Latest commit a4680d0
🔍 Latest deploy log https://app.netlify.com/sites/qui-docs/deploys/62cd3c44499ff70009ab2b04
😎 Deploy Preview https://deploy-preview-306--qui-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for qui-max ready!

Name Link
🔨 Latest commit a4680d0
🔍 Latest deploy log https://app.netlify.com/sites/qui-max/deploys/62cd3c4465e7db0008f22d88
😎 Deploy Preview https://deploy-preview-306--qui-max.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Co-authored-by: Sergey <serega-nsk93@yandex.ru>
@shamilfrontend
Copy link
Member

@VasiliyRusin

https://github.com/Qvant-lab/qui-max/blob/q-checkbox-redesign/src/qComponents/QCheckbox/src/QCheckbox.vue

  1. вынести с 5 по 9 строку в компьютед qCheckboxClasses с типом ClassValue

  2. вынести с 14 по 19 строку в компьютед qCheckboxInputClasses с типом ClassValue

  3. вынести с 27 по 30 строку в компьютед qCheckboxInnerIconClasses с типом ClassValue

  4. Типизировать все пропсы через as PropType

  5. Экспортировать все типи пропсов из главного index.ts компонента

@@ -30,6 +35,7 @@ const Template: Story<QCheckboxProps> = args =>
:indeterminate="args.indeterminate"
:disabled="args.disabled"
:rootTag="args.rootTag"
:labelSize="args.labelSize"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кебаб

@ViZhe ViZhe changed the title feat(QCheckbox): checkbox redesign feat(QCheckbox): add labelSize props and redesign Jun 23, 2022
@cheesytim cheesytim self-requested a review June 27, 2022 12:11
@cheesytim cheesytim merged commit b7a97e6 into main Jul 12, 2022
@cheesytim cheesytim deleted the q-checkbox-redesign branch July 12, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants