Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec stack trace invisible in iTerm2 with dark theme #66

Closed
mikem opened this issue Apr 17, 2011 · 3 comments
Closed

RSpec stack trace invisible in iTerm2 with dark theme #66

mikem opened this issue Apr 17, 2011 · 3 comments

Comments

@mikem
Copy link

mikem commented Apr 17, 2011

The RSpec stack trace shown when a spec fails is pretty much invisible in iTerm2 with the dark theme:

rspec stack trace

I highlighted the second line of the stack trace to make it legible.

Is this something that can be tweaked, or does RSpec need a Solarized theme of its own?

@leehambley
Copy link

I believe this is a duplicate of #58 - which the author doesn't want to pull. I believe the problem is that dark black is the same as background-color.

@garybernhardt
Copy link

I reported this to RSpec and Dave Chelimsky adjusted RSpec's colors to make the traceback visible. It was previously using the "bright black" color, which is the same as Solarized's background color. The 2.6.4 release of rspec-core has the fix. I think that this issue can be safely closed now.

@mikem
Copy link
Author

mikem commented Jul 10, 2011

Yep, the issue no longer exists with RSpec 2.6.4.

@mikem mikem closed this as completed Jul 10, 2011
xnox pushed a commit to xnox/solarized that referenced this issue Sep 9, 2012
the sRGB fix is not necessary for Mac build 3.2+, also post Mountain Lion? (need confirmation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants