Chiara/websockets cherrypicking #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new and improved version of the checkin loop no longer needs to wait for ops to send responses to http requests in order to complete the checkin flow and receive operator updates. Now, with the websocket replacement loop we can be sure ops has received data and not block on whether or not we receive an OperatorUpdateMessage as ops will process separately and send back on its own time. The websocket loop will keep trying to connect to ops even if connection is dropped or refused (as in cases where ops restarts)
We now send websocket messages as a variant of an enum type to make deserialization easier. This change also groups related(processed together on ops) data together to simplify and reduce ops db load, as it doesn't make sense to send individual messages for every piece of data when a DB read/write to a device entry is needed for processing. Previously used, now-legacy checkin and update structs have been kept but moved to the legacy.rs file to allow ops to retain function for older routers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.