Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Launch app for Web #409

Merged
merged 1 commit into from
May 10, 2024
Merged

fix: Launch app for Web #409

merged 1 commit into from
May 10, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented May 10, 2024

🔗 Related Issues

🙌 What's Done

  • Fix UserDevice (Use sealed class)
  • dart:isolate is note used on the web

✍️ What's Not Done

🖼️ Image Differences

image

image

📝 Additional Notes

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (c5160cd) to head (70739e0).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9c514...70739e0. Read the comment docs.

@riscait riscait marked this pull request as ready for review May 10, 2024 02:02
@riscait riscait requested a review from a team as a code owner May 10, 2024 02:02
@riscait riscait requested review from naipaka and removed request for a team May 10, 2024 02:02
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait merged commit 58a0704 into main May 10, 2024
9 checks passed
@riscait riscait deleted the 376-fix-web-launching branch May 10, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White screen when launching app on Chrome
2 participants