Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Scala 3 enum serializer #278

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Adds Scala 3 enum serializer #278

merged 8 commits into from
Mar 1, 2022

Conversation

nvollmar
Copy link
Member

@nvollmar nvollmar commented Feb 28, 2022 •
edited
Loading

refs #277

danischroeter
danischroeter approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@danischroeter danischroeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides code pls add some doc describing the bug/missing feature in the linked issue for reference...

...in/scala-3/io/altoo/akka/serialization/kryo/serializer/scala/ScalaCollectionSerializer.scala Show resolved Hide resolved
@nvollmar
Copy link
Member Author

Was planning to, didn’t have the time yet

@nvollmar nvollmar force-pushed the wip-277-scala3-enum-nvo branch from c5996b3 to 5ab8297 Compare March 1, 2022 06:25
@nvollmar nvollmar merged commit 557763b into master Mar 1, 2022
@nvollmar nvollmar deleted the wip-277-scala3-enum-nvo branch March 1, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danischroeter danischroeter danischroeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvollmar @danischroeter