Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Add more unit test cases e.g. ResNet FrozenDict #3

Merged
merged 14 commits into from
Dec 24, 2022
Merged

🧪 Add more unit test cases e.g. ResNet FrozenDict #3

merged 14 commits into from
Dec 24, 2022

Conversation

alvarobartt
Copy link
Owner

@alvarobartt alvarobartt commented Dec 24, 2022 •
edited
Loading

✨ Features

  • Add flaxmodels.resnet.ResNet50 in both tests/ and benchmarks/
  • Run ruff and black over both examples/ and benchmarks/ too

🧪 Tests

  • Did you implement unit tests if required?

If the above checkbox is checked, describe how you unit-tested it.

Keep the same unit tests but add ResNet50 as a pytest.fixture in order to test safejax on more complex FrozenDict structures.

@alvarobartt alvarobartt self-assigned this Dec 24, 2022
@alvarobartt
➕ Add pytest-lazy-fixture dependency
48fb961 
More information at https://github.com/tvorog/pytest-lazy-fixture
@alvarobartt
➕ Add flaxmodels dependency
393d650 
More information at https://github.com/matthias-wright/flaxmodels
@alvarobartt
🧪 Extend unit tests to run over ResNet50
941d26b 
`Resnet50` has been imported from `flaxmodels` and the weights are ported in `flaxmodels` from https://github.com/pytorch/vision
@alvarobartt
🔖 Set 0.1.1 version
3919fc2
@alvarobartt
🔀 Merge pull request #4 from alvarobartt/update-version
f39907d 
⬆️ Upgrade `safejax` to 0.1.1
@alvarobartt
✨ Add benchmarks/ for SingleLayer and ResNet50
70c3f74 
Split between scripts intended to be run with Python and the ones intended to be run with `hyperfine`
@alvarobartt
📝 Update README.md
4047baf
@alvarobartt
🔀 Merge pull request #5 from alvarobartt/benchmark-resnet
473ced7 
✨ Add `benchmarks/resnet50.py`
@alvarobartt
🎨 Make ruff smile again
cb2b545
@alvarobartt
👷🏻‍♂️ Run ruff and black over benchmarks/ and examples/
bd77e79
@alvarobartt alvarobartt changed the title 🧪 Add more detailed/complex unit tests 🧪 Add more unit test cases e.g. ResNet FrozenDict Dec 24, 2022
@alvarobartt alvarobartt marked this pull request as ready for review December 24, 2022 15:48
@alvarobartt alvarobartt merged commit 1b871c9 into main Dec 24, 2022
@alvarobartt alvarobartt deleted the more-tests branch December 24, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alvarobartt alvarobartt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alvarobartt