Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDOM.render is no longer supported in React 18 #441

Closed
alvarotrigo opened this issue Dec 8, 2024 · 2 comments
Closed

ReactDOM.render is no longer supported in React 18 #441

alvarotrigo opened this issue Dec 8, 2024 · 2 comments
Labels
documentation enhancement New feature or request

Comments

@alvarotrigo
Copy link
Owner

Description

ReactDOM.render is no longer supported in React 18.
The examples need to be updated to fix that.

@alvarotrigo alvarotrigo added enhancement New feature or request documentation labels Dec 8, 2024
@alvarotrigo
Copy link
Owner Author

The examples use the old syntaxt:

const rootElement = document.getElementById('react-root');
ReactDOM.render(<App />, rootElement);

We probably need to update it for this instead?

import ReactDOM from 'react-dom/client';

const root = ReactDOM.createRoot(document.getElementById('react-root'));
root.render(<Fullpage />);

Would that be enough @jason-warner , @AbobkerElaghel, @ankitsinghaniyaz, @cmswalker?

@alvarotrigo
Copy link
Owner Author

Alright! I think it is enough :)
But if you have any other suggestions I'll be happy to add them too!

Merged into 0.1.46! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant