Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #63

Closed

Conversation

shahzore-qureshi
Copy link

This is a fix for the scrollOverflow functionality not working. I spent hours debugging this, and I realized this CSS file was missing.

This is a fix for the scrollOverflow functionality not working. I spent hours debugging this, and I realized this CSS file was missing.
@alvarotrigo
Copy link
Owner

The CSS file is include by default, see how the component includes it here:
https://github.com/alvarotrigo/react-fullpage/blob/master/components/ReactFullpage/index.js#L5

You can also see it on the dist file:
https://github.com/alvarotrigo/react-fullpage/blob/master/dist/react-fullpage.js#L5099

@cmswalker I think we need to get rid of it on the example file if we want to be consistent?
https://github.com/alvarotrigo/react-fullpage/blob/master/example/dist/index.html#L13

We'll probably need to change the webpack config for that?

@alvarotrigo alvarotrigo added the question Further information is requested label Nov 10, 2018
@cmswalker
Copy link
Collaborator

Yes lets scrap it in example

@shahzore-qureshi
Copy link
Author

I tried that, but the CSS did not take effect. Ah well. Thanks for the quick response. It's probably an issue on my end.

@alvarotrigo
Copy link
Owner

@shahzore-qureshi did you check if it was building the bundle file properly? Maybe it skipped the CSS inclusion due to lack of npm packages to include it?

@alvarotrigo
Copy link
Owner

Yes lets scrap it in example

Done!
I modified the package.json and the webpack.config.js files in order to solve it and add the CSS on the example build.
If there's anything you want to change let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants