Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent string case for channel name checks #169

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Aug 2, 2024

We have alveussanctuary in the default set of channel names, so when the extension is active in this channel it should not be watching the extra channel names including alveusgg. However, as seen in recent collaborations, commands run in alveusgg where controlling the extension in alveussanctuary.

After some investigation, the issue stems from the broadcaster_name for alveussanctuary actually being AlveusSanctuary. I've solved this in a few different places for some redundancy -- switching to broadcaster_login gives us back alveussanctuary instead, and then I've ensured we're normalizing all the values used for these name checks to always be lowercase.

@MattIPv4 MattIPv4 requested a review from pjeweb August 2, 2024 01:56
@MattIPv4 MattIPv4 merged commit 623a0b5 into main Aug 2, 2024
2 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-channel-name-checks branch August 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants