Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from x/crypto for pkcs12 (no longer maintained) #13

Merged
merged 1 commit into from
Nov 18, 2023
Merged

switch from x/crypto for pkcs12 (no longer maintained) #13

merged 1 commit into from
Nov 18, 2023

Conversation

ryan-lang
Copy link
Contributor

I ran into the following bug when signing certs with the latest digest algorithms: golang/go#62375. It does not appear likely that it will be fixed, as the x/crypto docs for pkcs12 say: "This package is frozen. If it's missing functionality you need, consider an alternative like software.sslmate.com/src/go-pkcs12."

This commit replaces x/crypto with sslmate's drop-in replacement.

Copy link
Owner

@alvinbaena alvinbaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay

@alvinbaena
Copy link
Owner

Approved

@alvinbaena alvinbaena merged commit 72d70e1 into alvinbaena:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants