NumPy implementation of unravel().
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flamegraph, it looks like this is much more performant than before!
alxmrs
changed the title
unravel().unravel().
|
@cisaacstern Check this out, I think qarray is getting interesting! |
alxmrs
commented
Feb 16, 2024
| coords = np.empty((N, DD)) | ||
| for i, c in enumerate(itertools.product(*[ds.coords[v] for v in dim_keys])): | ||
| coord = np.array(c) | ||
| coords[i] = coord |
There was a problem hiding this comment.
Omit the loop and just create the array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I put forth a significantly faster implementation of unravel that uses an unbounded amount of memory. Since we use NumPy operations, everything is much faster (due to vectorization).
We won't have to worry about unbounded memory when converting to Dask dataframes, since we default to use Xarray chunks.
This answers some questions in #8.