don't stop() if there are unmatched column types

fixes tidyverse#145
alyst · May 4, 2015 · 9c6502c · 9c6502c
1 parent 518546a
commit 9c6502c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -9,3 +9,6 @@
 * When guessing field types, and there's no information to go on, use
   character instead of logical (#124, #128).
 
+* `read_XXX()` methods would not throw an error if `col_types` argument
+  specifies type for a missing column (#145 thanks @alyst).
+
diff --git a/R/col_types.R b/R/col_types.R
@@ -71,10 +71,10 @@ col_types_full <- function(col_types, col_names, guessed_types) {
 
     col_types
   } else {
-    bad_names <- setdiff(names(col_types), col_names)
-    if (length(bad_names) > 0) {
-      stop("The following named parsers don't match the column names: ",
-        paste0(bad_names, collapse = ", "), call. = FALSE)
+    unmatched_names <- setdiff(names(col_types), col_names)
+    if (length(unmatched_names) > 0) {
+      warning("The following named parsers don't match the column names: ",
+        paste0(unmatched_names, collapse = ", "), call. = FALSE)
     }
 
     skip <- setdiff(col_names, names(col_types))