Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/correctly parse crlf line endings #496

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

dossy
Copy link
Collaborator

@dossy dossy commented Nov 16, 2023

  • chore: add failing tests that demonstrate the issue
  • fix: correct migration parsing regexps

Fixes #213.

Copy link
Owner

@amacneil amacneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks!

feel free to merge PR after you fix the merge conflict

@dossy dossy force-pushed the fix/correctly-parse-crlf-line-endings branch from b212139 to c9600c8 Compare November 16, 2023 06:47
@dossy dossy enabled auto-merge (squash) November 16, 2023 07:49
@dossy dossy merged commit e87887f into amacneil:main Nov 16, 2023
9 checks passed
@dossy dossy deleted the fix/correctly-parse-crlf-line-endings branch November 16, 2023 17:28
@dossy
Copy link
Collaborator Author

dossy commented Nov 16, 2023

@amacneil Since this PR fixes a real bug that's impacting users, what are your thoughts on a timeframe for releasing v2.8.0?

@amacneil
Copy link
Owner

😄 https://github.com/amacneil/dbmate/releases/tag/v2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The first migration is always rolled back on Windows
2 participants