Server, Share, Directory and File browser implementation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it not inherit the dark "skin"? |
|
Updated the color scheme |
|
Shares screen |
| @@ -26,21 +25,21 @@ class SharesTableViewController: BaseUITableViewController { | |||
| presenter = SharesPresenter(self) | |||
There was a problem hiding this comment.
This is good. Seems you are very familiar with the MVP Architecture. Looks forward to working more with you on this project. @csoni111
| @@ -29,7 +29,7 @@ class DashboardPresenter: BasePresenter { | |||
|
|
|||
| self.view?.updateRefreshing(isRefreshing: true) | |||
| let access_token = LocalStorage.shared.getAccessToken() | |||
| FetchServers.shared.fetch(access_token: access_token) { (serverResponse) in | |||
| AmahiApi.shared.getServers(access_token: access_token) { (serverResponse) in | |||
There was a problem hiding this comment.
Why not append the access_token in ApiEndpoint file like this. static func servers() -> String { return "\(ApiConstants.BASE_URL)/paths_to_server/\(?access_token=\(LocalStorage().getAccessToken()!)" }
|
|
csoni111
changed the title
|
I have added the following:
Currently I have implemented only REMOTE mode for selecting the server url. AUTO and LOCAL Mode can be implemented after Settings screen is ready. I will cover App Browser in another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #8