Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use github.api_url as default githubBaseUrl #243

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Oct 27, 2023

Currently the GitHub API URL has to be set manually.
This will change that you do not longer need to set the input on a GHE instance.

This change uses the github context.

@amannn
Copy link
Owner

amannn commented Nov 3, 2023

Thanks for the proposed change! Were you able to test this change?

Generally, this looks good. Can you also mention the default in README.md?

Adding missing docs for action.yml and README.md
@fty4
Copy link
Contributor Author

fty4 commented Nov 3, 2023

I've added the missing documentation.

Yes - I tested the changes on a GHE instance and it worked without problems.

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 🙌

@amannn amannn merged commit 4d5734a into amannn:main Nov 3, 2023
7 checks passed
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants