-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No any logic for trailingSlash: true
#1184
Comments
trailingSlash: true
Hey @fejmek, thanks for the report! There was some previous discussion about this in #668. I just had another look and I think there might not be too much missing for this. I've just set up a test suite and will have a closer look if we could address this is in a timely manner. I'm looking into sharing a pre-release version with you as soon as my test suite is green. I'll be in touch again tomorrow! |
@fejmek A pre-release is available as Mind giving it a go in your app? 🙂 |
Awesome job! Thank u very much @amannn !! |
Awesome! I'll release this to stable now 🚀 |
Description
I looked through the entire application code and i haven't found any logic that would take into account that the application has option trailingSlashes set to true, when redirecting to the appropriate translated urls.
It makes no sense to create additional redirections and it is a big problem when we look at SEO.
I hope I have provided all the information you need
Verifications
Mandatory reproduction URL
https://github.com/fejmek/trailing-slash
Reproduction description
Steps to reproduce:
Expected behaviour
Just simple logic to implement trailing slashes to redirects.
The text was updated successfully, but these errors were encountered: