Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove experimental config for appDir and @next/font #328

Merged
merged 9 commits into from
Jun 20, 2023
Merged

refactor: Remove experimental config for appDir and @next/font #328

merged 9 commits into from
Jun 20, 2023

Conversation

grzegorzpokorski
Copy link
Contributor

Changes:

  • Removed experimental config for appDir because starting from nextjs v13.4, this feature is stable (for now in the console at development mode we have some warns about that this config is necessary but it was fixed in the latest version of nextjs),
  • Removed the @next/font package since it is now built into nextjs itself.

@vercel
Copy link

vercel bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-next-13-next-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:29pm
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:29pm
next-intl-example-next-13 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:29pm

@vercel
Copy link

vercel bot commented Jun 12, 2023

@grzegorzpokorski is attempting to deploy a commit to the next-intl Team on Vercel.

A member of the Team first needs to authorize it.

amannn
amannn reviewed Jun 19, 2023
View reviewed changes
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR, always great to see old cruft removed! 🙌

examples/example-next-13-next-auth/next.config.js Outdated Show resolved Hide resolved
examples/example-next-13/next.config.js Outdated Show resolved Hide resolved
amannn
amannn reviewed Jun 19, 2023
View reviewed changes
pnpm-lock.yaml Show resolved Hide resolved
amannn
amannn approved these changes Jun 20, 2023
View reviewed changes
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 🙌

@amannn amannn merged commit 6540645 into amannn:main Jun 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amannn amannn amannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzegorzpokorski @amannn