lets play nice with react-native(metro) #1344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also @amark we need to run a unbuild update if possible ( look like src folders are out of date) |
|
😭 😭 😭 6 years ago this was originally how we fixed things, but then it broke so we switched to 5 other approaches over each half year. So I always get nervous about these...by chance have a checklist of this working in:
|
|
this may be no longer needed, because of #1254 |
bmatusiak
commented
Dec 20, 2023
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expo/react-native does not like the use of
require(var)so the work around is to re name it