adopting a style guide #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retty well) added `npm run lint` and `npm run lint-fix` which automatically fixes what it can
|
0.5 tests are failing anyways (not you) so no worries. I noticed you already closed these pull requests. Not sure why - but I'm fine with that, because I generally dislike style-guides. Although your last point is actually the most convincing thing I've ever read on the issue (prevent git commit diffs from formatting problems). Anyways, not sure why you closed these but I'm fine with leaving them closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for running the code through the google javascript style guide, it seems that the code almost conforms to the guide already. If the pull is accepted, I'll run through the warnings and fix them all.
In order to see where the code doesn't conform to the styleguide:
To automatically clean up code where it can be:
eslint supports changing defaults (tabs vs spaces), but the default for the google stylesheet is 2 spaces. I looked at the code and there were way more uses of spaces than tabs.
Personally, I don't have a strong opinion, except that the format should be consistent so that pull requests don't get polluted by irrelevant formatting.