Fixed random test failure in Watchman watchers #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r that also reduced the number of direct clients of watchman.Client to 1 per process
…fix for _next in backoff timer
… the instance to close into WatchmanClient, resulted in spurious events
…hman.Client if the process gets interrupted
stefanpenner
requested changes
Feb 8, 2018
|
|
||
| // Define a handler for if somehow the Node process gets interrupted. We need to | ||
| // close down the watchman.Client, if we have one. | ||
| process.on('SIGINT', () => { |
There was a problem hiding this comment.
Two issues:
- This can leak memory. If a
sanesession using watchman is no longer being used, it will be retained by theprocess.on('SIGINT'handler until the process shutdown (or SIGINT) is worked - This wont handle other forms of shutdown, such as the process simply ending when it has no more work to do.
Ideas to resolve:
- the global cleanup handler needs to be disabled via
offduringWatchmanWatcher.prototype.close - use capture-exit to handle all reasonable forms of exit + cooperation with other libraries attempting to do the same.
|
|
I created a separate PR (#119) for the exit handling, since this PR shows as 'unknown repository'. I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent updates to WatchmanWatcher contained a bug where when the test harness told a watcher to close down, it would tell the new WatchmanClient to remove the watcher from the listeners, but forgot to pass the WatchmanWatcher instance so nothing was getting closed/removed, resulting in spurious events later because the listener hadn't been removed.