Prevent change on add in node watcher

[xdissent]

Turns change events into add events if the add event hasn't yet been emitted. Fixes #75.

[amasad]

This should never happen since we filter change events on dirs here.

Any idea how to reproduce this locally? I wasn't able to.

[xdissent]

If you clone the pr branch and git checkout origin/master -- src/node_watcher.js the test should fail in linux. I pushed a docker image you can run with docker run --rm xdissent/sane:pr-86. Here's the dockerfile:

FROM node:7-alpine
RUN apk add --update git
WORKDIR /sane
RUN git clone -b bug/change-on-add https://github.com/xdissent/sane.git . && \
  git checkout origin/master -- src/node_watcher.js && \
  npm i -s --unsafe-perm
CMD ["npm", "test"]

[amasad]

@xdissent thanks for the dockerfile. Very convenient. So I misunderstood that the change event is triggered on the directory. In this case can we just ignore the change event. No need to debounce the add event again. I'll leave an inline comment.

[amasad]

just return from here. And add a comment to say something like:

// Ignore the change event that is immediately fired after an add event.
// (This happens on Linux).

[amasad]

should we do a release soon or do you have other things in the works/needs addressing for watchpack? /cc @wtgtybhertgeghgtwtg

[wtgtybhertgeghgtwtg]

If it's a minor release, I don't have any complaints. I'd like to get #90 in, but it's breaking/not vital.

[amasad]

published 1.6