Adding Support for ResourceName S3Buckets

**Why:** * Allows you to use the same `resourceName` for your s3buckets **This change addresses the need by:** * closes #52 Signed-off-by: Christopher Hein <me@christopherhein.com>
amazon-archives · Aug 25, 2018 · 0b174a4 · 0b174a4
1 parent 6474c2f
commit 0b174a4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/examples/s3bucket.yaml b/examples/s3bucket.yaml
@@ -3,7 +3,6 @@ kind: S3Bucket
 metadata:
   name: chrishein-test-bucket-109
 spec:
-  bucketName: chrishein-test-bucket-name-109
   versioning: false
   logging:
     enabled: false

diff --git a/models/s3bucket.yaml b/models/s3bucket.yaml
@@ -19,7 +19,7 @@ spec:
       type: object
       properties:
       - key: bucketName
-        type: string
+        type: resourceName
         description: |
           BucketName is the name of the S3 Bucket to be created.
         structKey: BucketName

diff --git a/pkg/operator/s3bucket/cft.go b/pkg/operator/s3bucket/cft.go
@@ -75,7 +75,7 @@ func (s *Cloudformation) CreateStack() (output *cloudformation.CreateStackOutput
 	resourceVersion := helpers.CreateParam("ResourceVersion", s.S3Bucket.ResourceVersion)
 	namespace := helpers.CreateParam("Namespace", s.S3Bucket.Namespace)
 	clusterName := helpers.CreateParam("ClusterName", s.config.ClusterName)
-	bucketName := helpers.CreateParam("BucketName", helpers.Stringify(s.S3Bucket.Spec.BucketName))
+	bucketName := helpers.CreateParam("BucketName", helpers.Stringify(s.S3Bucket.Name))
 	versioning := helpers.CreateParam("EnableVersioning", helpers.Stringify(s.S3Bucket.Spec.Versioning))
   loggingenabled := helpers.CreateParam("EnableLogging", helpers.Stringify(s.S3Bucket.Spec.Logging.Enabled))
   loggingprefix := helpers.CreateParam("LoggingPrefix", helpers.Stringify(s.S3Bucket.Spec.Logging.Prefix))
@@ -128,7 +128,7 @@ func (s *Cloudformation) UpdateStack(updated *awsV1alpha1.S3Bucket) (output *clo
 	resourceVersion := helpers.CreateParam("ResourceVersion", s.S3Bucket.ResourceVersion)
 	namespace := helpers.CreateParam("Namespace", s.S3Bucket.Namespace)
 	clusterName := helpers.CreateParam("ClusterName", s.config.ClusterName)
-	bucketName := helpers.CreateParam("BucketName", helpers.Stringify(updated.Spec.BucketName))
+	bucketName := helpers.CreateParam("BucketName", helpers.Stringify(s.S3Bucket.Name))
 	versioning := helpers.CreateParam("EnableVersioning", helpers.Stringify(updated.Spec.Versioning))
 	loggingenabled := helpers.CreateParam("EnableLogging", helpers.Stringify(updated.Spec.Logging.Enabled))
 	loggingprefix := helpers.CreateParam("LoggingPrefix", helpers.Stringify(updated.Spec.Logging.Prefix))