This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Update Documentation for installing codegen tool #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Documentation for installing codegen points to a non-existent repository. Updated docs to install from the source code added to the main repository in commit hash 14e2679 and use the included make files. Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
tantona
reviewed
Nov 2, 2018
| cd code-generation | ||
| make install-bindata | ||
| cd .. | ||
| make install-aws-codegen |
There was a problem hiding this comment.
can you update the Makefile at the root of the project so this is a single step run from the root?
ie. make install-aws-codegen -> installs-bindata and installs aws-codegen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to install from the source code added to the main repository in commit hash
14e2679 and use the included make files.
Signed-off-by: Robert Marshall rmarshall@gitlab.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.