This repository has been archived by the owner on Jun 2, 2021. It is now read-only.
Allow maxDescriptorsPerIpSet and maxDescriptorsPerIpSetUpdate to be configured as job arguments #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
maxDescriptorsPerIpSetandmaxDescriptorsPerIpSetUpdateas arguments, so users can tune this value without having to maintain their own separate Lambda function. Right now, the limit is 1,000, which is the default, but if that becomes tunable via a limit increase request in the future, users will need to be able to increase these numbers.I've also added the ability to
npm run buildto generatelambda.zip, to make it easier to maintain. You'll need the 7-Zip CLI in yourPATH(brew install p7zip,choco install 7zip.commandline,apt-get install p7zip, etc.).If you require a contributor agreement to be signed, let me know and I'll sign that. Otherwise, I disclaim all copyright claims to this contribution.