This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-node export using --section/--totalSections is currently broken.
ParallelScanExecutor
creates a BitSet to track which segments are completed, and terminates whenfinished.cardinality() == workers.length
which can only be true if totalSections is 1. If totalSections > 1, then finished.cardinality() will always be less than workers.length. While the code does eventually copy the entire table, it never terminates.This change is sort of a hacky way to unblock me. Probably the right thing is to have ParallelScanExecutor have an expected bitset (the segments that should be completed) and a finished bitset of which ones have completed, and compares the two.