fix: checking all notebooks for unavailable devices. #142
Conversation
| return device.arn, False | ||
|
|
||
| content = file.read() | ||
| for device in unavailable_devices: |
There was a problem hiding this comment.
Do we want to add a buffer for the availability of checking for availability for + x mins in the future?
There was a problem hiding this comment.
I agree, buffer would be required in future if the notebooks is being executed and device becomes unavailable next minute. But that would be a race condition kind of thing.
There was a problem hiding this comment.
The problem is that it would get a lot more complicated, because we just look at availability times, we don't actually forecast when it's available.
It would be quite a change to try and forecast how long the notebook would take to run and figure out if the device will be available - and it wouldn't quite work if devices are taken offline for other reasons.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.