Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re organise github mobile examples; Consolidating all mobile examples #166

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

mrajatttt
Copy link
Collaborator

Issue #, if available:

Description of changes:

I will edit the links in this folder's readme once this PR is merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrajatttt mrajatttt requested a review from a team as a code owner January 5, 2024 05:38
@mrajatttt mrajatttt requested review from haomingli2020 and spenlep-amzn and removed request for a team January 5, 2024 05:38
@spenlep-amzn
Copy link
Collaborator

spenlep-amzn commented Jan 5, 2024

@mrajatttt can we try to get React Native CI to pass, if it is simple fix?

Update reactnative-node-ci.yml
spenlep-amzn
spenlep-amzn previously approved these changes Jan 5, 2024
Copy link
Collaborator

@spenlep-amzn spenlep-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to follow naming convention and use lowercase though? mobileChatExamples

spenlep-amzn
spenlep-amzn previously approved these changes Jan 18, 2024
Copy link
Collaborator

@spenlep-amzn spenlep-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to follow naming convention and use lowercase though? mobileChatExamples

@mrajatttt mrajatttt merged commit 5f5f49e into master Jan 19, 2024
1 check passed
@mrajatttt mrajatttt deleted the rajatttt/patch branch January 19, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants