forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit pod status metrics for pending pods from api server #139
Merged
mitali-salvi
merged 13 commits into
amazon-contributing:aws-cwa-dev
from
mitali-salvi:pod-pending-fix
Nov 9, 2023
Merged
Emit pod status metrics for pending pods from api server #139
mitali-salvi
merged 13 commits into
amazon-contributing:aws-cwa-dev
from
mitali-salvi:pod-pending-fix
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitali-salvi
commented
Nov 9, 2023
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
mitali-salvi
commented
Nov 9, 2023
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
sky333999
reviewed
Nov 9, 2023
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Outdated
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
receiver/awscontainerinsightreceiver/internal/k8sapiserver/k8sapiserver.go
Show resolved
Hide resolved
} | ||
|
||
type Option func(*K8sAPIServer) | ||
|
||
// NewK8sAPIServer creates a k8sApiServer which can generate cluster-level metrics | ||
func NewK8sAPIServer(cnp clusterNameProvider, logger *zap.Logger, leaderElection *LeaderElection, options ...Option) (*K8sAPIServer, error) { | ||
func NewK8sAPIServer(cnp clusterNameProvider, logger *zap.Logger, leaderElection *LeaderElection, addFullPodNameMetricLabel bool, includeEnhancedMetrics bool, options ...Option) (*K8sAPIServer, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we use the option pattern so the signature doesnt have to change everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be taken care of as part of the code cleanup task
sky333999
approved these changes
Nov 9, 2023
movence
approved these changes
Nov 9, 2023
mitali-salvi
merged commit Nov 9, 2023
ef547b1
into
amazon-contributing:aws-cwa-dev
59 of 71 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pending pod metrics are not being emitted from the pod store due to cadvisor running on individual node and since pending pods are not assigned to any node, they dont show up
Testing: