Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds github action for CI. (#11) #12

Closed
wants to merge 1 commit into from
Closed

Conversation

u5surf
Copy link

@u5surf u5surf commented Jun 13, 2021

Issue #11

Description of changes:

I ported CI settings from amzn/ion-rust and partiql/partiql-lang-rust.
Although, It seems not to be seen any tests at all. I wonder how come it needs test coverages for now.
For its CI is failed for this reason, I marked draft for this PR.

@zslayton
Copy link
Contributor

Thanks for the PR!

Although, It seems not to be seen any tests at all.

Yes, ideally we'd have at least a few basic tests for the ion dump command to test this configuration. If you're up for it, you can look at what pest2ion (part of partiql-lang-rust) did for its CLI tests.

@zslayton
Copy link
Contributor

zslayton commented Aug 2, 2021

@u5surf Are you interested in adding some simple tests to this PR?

@u5surf u5surf marked this pull request as ready for review March 26, 2022 07:19
@zslayton
Copy link
Contributor

Closing this as @camerondurham addressed this in #22.

@zslayton zslayton closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants